smengcl commented on PR #11328: URL: https://github.com/apache/ozone/pull/11328#issuecomment-6067855128
> > Thanks @yandrey321 . > > There is room to [reduce ~350 LOC in prod code](https://github.com/smengcl/hadoop-ozone/commit/da8b130abeb76e0434495d3cda505910be2fb7ff) but I am fine with this as-is. > > we can open a separate JIRA for refactoring and simplification, IMHO we should not suppress method length warning in new/updated methods. If we touch methods with this suppress annotation we should invest some time into decomposing them into smaller one and making them more readable. Yes usually we do big refactoring in a separate PR, not just for earier review, but also for less headache for future maintenance (like when backporting to older branches). https://github.com/apache/ozone/pull/7639#issuecomment-2574541829 https://github.com/apache/ozone/pull/11102#issuecomment-5529815034 https://github.com/apache/ozone/pull/9132#pullrequestreview-3512948976 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
