ivandika3 commented on code in PR #11421:
URL: https://github.com/apache/ozone/pull/11421#discussion_r4226330665
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMMetrics.java:
##########
@@ -222,34 +217,25 @@ public class OMMetrics implements OmMetadataReaderMetrics
{
private @Metric MutableGaugeLong numVolumes;
private @Metric MutableGaugeLong numBuckets;
- private @Metric MutableCounterLong numS3Buckets;
//TODO: This metric is an estimate and it may be inaccurate on restart if the
// OM process was not shutdown cleanly. Key creations/deletions in the last
// few minutes before restart may not be included in this count.
private @Metric MutableGaugeLong numKeys;
- private @Metric MutableCounterLong numBucketS3Creates;
- private @Metric MutableCounterLong numBucketS3CreateFails;
- private @Metric MutableCounterLong numBucketS3Deletes;
- private @Metric MutableCounterLong numBucketS3DeleteFails;
-
private @Metric MutableCounterLong numListMultipartUploadFails;
private @Metric MutableCounterLong numListMultipartUploads;
// Metrics related to OM Trash.
private @Metric MutableCounterLong numTrashRenames;
private @Metric MutableCounterLong numTrashDeletes;
private @Metric MutableCounterLong numTrashListStatus;
- private @Metric MutableCounterLong numTrashListKeys;
- private @Metric MutableCounterLong numTrashGetFileStatus;
Review Comment:
Please hold off removing `numTrashGetFileStatus` until
https://github.com/apache/ozone/pull/11364 is resolved. This metric should
technically be used for all `TrashOzoneFileSystem` usages.
cc: @yandrey321
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
