smengcl commented on code in PR #11377:
URL: https://github.com/apache/ozone/pull/11377#discussion_r4234099398
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRequest.java:
##########
@@ -1094,6 +1124,9 @@ protected OmKeyInfo createFileInfo(
if (keyArgs.hasExpectedDataGeneration()) {
builder.setExpectedDataGeneration(keyArgs.getExpectedDataGeneration());
}
+ if (keyArgs.hasStoragePolicy()) {
Review Comment:
IMO a no-policy overwrite should resolve the policy the same way as a new
key: bucket policy, then cluster default?
`preExecute()` already resolves and stamps that policy into `KeyArgs`, so
the existing-key path sees it and records the new value. No need to clear the
field or preserve the old policy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
