[ 
https://issues.apache.org/jira/browse/HDDS-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated HDDS-16835:
----------------------------------
    Labels: pull-request-available  (was: )

> Remove unreachable endsWith branch in S3 ListObjects delimiter handling
> -----------------------------------------------------------------------
>
>                 Key: HDDS-16835
>                 URL: https://issues.apache.org/jira/browse/HDDS-16835
>             Project: Apache Ozone
>          Issue Type: Bug
>          Components: S3
>            Reporter: Chi-Hsuan Huang
>            Priority: Minor
>              Labels: pull-request-available
>
> In {{BucketEndpoint#handleGetRequest}}, the {{else if 
> (relativeKeyName.endsWith(delimiter))}} branch can never run. It is only 
> reached when {{relativeKeyName}} does not contain the delimiter, so it cannot 
> end with it either.
> The case it was meant for (prefix {{dir}}, key {{dir/}}) is already handled 
> by the first branch, which adds the common prefix {{dir/}}.
> The branch has been unreachable since it was added in HDDS-444. Removing it 
> keeps all {{TestBucketList}} tests passing.
> Noticed while reviewing HDDS-16748.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to