[
https://issues.apache.org/jira/browse/HDDS-16536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18125972#comment-18125972
]
Siyao Meng commented on HDDS-16536:
-----------------------------------
Verification run complete. The Specula pipeline ran all phases against the
pinned commit: code analysis, TLA+ specification generation, harness and trace
collection, trace validation plus TLC model checking, bug confirmation with the
adversarial Challenger debate, and severity classification.
h3. Run environment
{noformat}
Ozone commit: b0aa6475b7856d2c7f467dd3db12b9a1dd116f63
Specula: v1.0.0-56-g62f63a1e (with local changes)
Agent/model: claude-code, Claude Opus 5.5 (1M context)
Effort: medium
TLC limits: 40G memory, 20 workers
Total: 6h 41m agent time, 89.3M tokens, about $60 (estimate)
{noformat}
h3. Result
11 candidate findings came out of model checking (6) and code review (5), and
all 11 were investigated individually.
||Disposition||Count||
|Reproduced|3|
|Masked (defect present, harm prevented by another component today)|3|
|False positive|5|
Each reproduced finding was then validated a second time by hand against the
pinned commit: a regression test was added to an existing suite and shown to
fail without the fix and pass with it, the bug was confirmed still present on
apache master (checked on 2026-10-11), and the fix patch, reproduction and
report were reviewed independently before filing.
h3. Filed
||Issue||Priority||Summary||
|HDDS-16898|Major|ReplicationManager resends an expired force DELETE to the
last known replica of a container after the other replicas are lost|
|HDDS-16897|Minor|Datanode runs a resent DeleteContainerCommand against a
replica imported after the command arrived, so a balancer move can leave the
container under replicated while reporting COMPLETED|
|HDDS-16886|Minor|Container move is reported COMPLETED when ReplicationManager
deletes the source replica before the target replica exists|
|HDDS-16885|Minor|TestMoveManager negative checks verify the wrong
sendDeleteCommand overload and cannot fail|
Priorities follow the manual validation, not the pipeline's severity classes.
Each issue has a proposed fix patch and a standalone reproduction test
attached; HDDS-16885 is a test only fix of a masked finding.
h3. Not filed
* Masked: a NotLeaderException after a successful ADD leaves a stale move
tracking entry. The balancer clears it at the start of every iteration and
never selects the same container twice per iteration.
* Masked: resetting or stopping the balancer during a copy drops the pending
moves without completing them. ReplicationManager removes the extra replica
later, and callers do not hang.
* The five false positives were judged not to hold on a running SCM: invariant
artifacts of the model, unreachable orderings, or intended behaviour.
h3. Reproduce
{code:none}
specula run --agent=claude-code --effort=medium --model='claude-opus-5-5[1m]' \
--max-parallel=2 --enable-reviews --confirm-debate \
--tlc-memory-limit=40G --tlc-worker-limit=20 \
"scm-container-move|apache/ozone|Java|Use the target-specific guidance"
{code}
h3. Caveats
* HDDS-16898 was run with real SCM components: SCM resends the force DELETE to
the last known replica. The datanode deleting that replica was shown at unit
level, not on a cluster, and permanent loss needs the other replica holders to
be lost within one move timeout.
* HDDS-16898 and HDDS-16897 come from the same resend added by HDDS-12127.
HDDS-16447 proposes another precondition on the same resend; its patch and the
HDDS-16898 patch change the same lines and should be combined.
* HDDS-16897 needs a datanode report delayed by several minutes, a backed up
delete executor and a move that finishes within the resent command's deadline.
The datanode disk work was mocked.
* HDDS-16886 was reproduced through the move and ReplicationManager entry
points for Ratis containers, not through a running balancer task.
* The patches were built and tested on the pinned commit and apply to master at
6818707698c.
* The patches are proposals for review.
Generated with Specula (Claude Opus 5.5).
> [Specula] Verify scm-container-move (Apache Ozone master @b0aa647)
> ------------------------------------------------------------------
>
> Key: HDDS-16536
> URL: https://issues.apache.org/jira/browse/HDDS-16536
> Project: Apache Ozone
> Issue Type: Sub-task
> Reporter: Siyao Meng
> Assignee: Siyao Meng
> Priority: Minor
> Labels: help-wanted, specula
> Attachments: scm-container-move.guidance.md
>
>
> This is a runnable Apache Ozone formal-verification target for the Specula
> pipeline (TLA+ model checking plus trace validation against the real code).
> It has not been run yet. Anyone can pick it up: run Specula against the
> pinned commit, then report findings on this issue. Part of umbrella
> HDDS-15926.
> h3. Target
> {{scm-container-move}}. Scope and code entry points are in the attached
> guidance file [^scm-container-move.guidance.md].
> h3. Run environment
> {noformat}
> Apache Ozone commit: b0aa6475b7856d2c7f467dd3db12b9a1dd116f63
> Specula: https://github.com/specula-org/Specula (v1.1.0 or later)
> Toolchain: JDK 21, ~28 GB RAM for TLC, an LLM coding agent
> (claude-code or codex adapter)
> Runtime: hours per target; needs an agent API budget
> {noformat}
> h3. How to run
> # Clone Specula and install per its README; clone apache/ozone and check out
> the pinned commit above.
> # Place the attached guidance file as the target's .prompt-extra.md (see the
> Specula README for target layout).
> # Run:
> {code:none}
> specula run --agent=claude-code --effort=medium --keep-original
> --max-parallel=2 \
> --enable-reviews --confirm-debate --tlc-memory-limit=28G
> --tlc-worker-limit=8 \
> "scm-container-move|apache/ozone|Java|Use the target-specific
> .prompt-extra.md"
> {code}
> # Deliverables land under the run's {{.specula-output/}}:
> {{confirmed-bugs.md}}, {{bug-severity.md}}, {{summary.md}}, and
> {{confirmation/<id>/investigation.md}}.
> h3. Reporting results
> Comment here with the outcome (0 findings is still useful: it records the
> target as covered at this commit). For each confirmed bug, file a separate
> Ozone Bug and link it to this issue with the "Testing" link type ("Testing
> discovered").
> h3. Notes
> * The attached guidance file names an earlier commit ({{20e6a1c}}); use the
> commit above. Code entry-point line numbers in the guidance were captured at
> an earlier commit and may have shifted on this head; treat them as
> approximate. Specula re-analyzes the source, so the run does not depend on
> them.
> * Recon-building targets need a local Specula patch to skip Maven {{target/}}
> out-of-tree symlinks in {{snapshotlib._validate_source_tree}}, else the run
> crashes at finalize.
> * effort=medium is the tested default for large targets; effort=high can hit
> per-turn timeouts on the biggest ones.
> * Findings are proposals, to be confirmed by human review and testing before
> any fix is merged.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
