shuan1026 commented on code in PR #11293:
URL: https://github.com/apache/ozone/pull/11293#discussion_r4247732635
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -1241,6 +1269,9 @@ message KeyInfo {
// This allows a key to be created an committed atomically if the original
has not
// been modified.
optional uint64 expectedDataGeneration = 22;
+ optional uint64 retentionDate = 23;
+ optional RetentionConfig retentionConfig = 24;
+ optional bool legalHold = 25 [default = false];
Review Comment:
+1 on including Object Lock fields in `computeKeyInfoCompareSignature`.
OEP 16f4074 doesn't mention Snapshot Diff. @chungen0126, worth a one-liner
in the design doc that retention / legalHold changes are part of the snapdiff
signature (as implemented here), so later phases don't regress it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
