Copilot commented on code in PR #11507:
URL: https://github.com/apache/ozone/pull/11507#discussion_r4256001188
##########
AGENTS.md:
##########
@@ -22,7 +22,8 @@ Apache Ozone is a multi-module Maven project. The root
coordinates and version l
Tech stack:
-- Java 8 bytecode with JDK 21 runtime compatibility (see the `[21,]` profile
in `pom.xml`)
+- Java 17 by default (`ozone.java.version.server` in `pom.xml`). Modules that
set `maven.compiler.release` to
+ `${ozone.java.version.client}` in their own `pom.xml` still target Java 8.
Review Comment:
The guidance is accurate, but it’s a bit implicit that only some modules
override `maven.compiler.release`. Consider adding a short pointer on how to
verify a module’s effective target (e.g., by checking the module `pom.xml` for
`maven.compiler.release` or by running Maven to print the effective POM). This
makes it easier for agents to reliably determine whether Java 8 rules apply
without guessing.
##########
AGENTS.md:
##########
@@ -52,7 +53,7 @@ server-side handling, client translation code, and
integration tests.
## Local Environment
-- Use a JDK 21 runtime locally. Source and target compatibility remain Java 8.
+- Use a JDK 21 runtime locally. Before using Java 9+ language features or
APIs, check that the module does not target Java 8.
Review Comment:
This line mixes 'language features' and 'APIs' under a Java 8 targeting
check. Even if a module targets Java 8, it can still compile against newer JDK
APIs depending on toolchain/config, but will fail at runtime or compilation
depending on `--release`. Consider clarifying that the restriction is governed
by `maven.compiler.release`/`--release` (language + standard library API
surface), so the instruction matches what Maven enforces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
