devmadhuu commented on code in PR #11399:
URL: https://github.com/apache/ozone/pull/11399#discussion_r4282326340
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancerTask.java:
##########
@@ -896,8 +935,11 @@ private ContainerMoveSelection
matchSourceWithTarget(DatanodeDetails source) {
Set<ContainerID> toRemoveContainerIds = new HashSet<>();
for (ContainerID containerId: sourceContainerIDSet) {
if (selectionCriteria.shouldBeExcluded(containerId, source,
- sizeScheduledForMoveInLatestIteration)) {
- toRemoveContainerIds.add(containerId);
+ sizeScheduledForMoveInLatestIteration, storageType)) {
+ // A different tier may still consider this container with its own
utilization bounds.
+ if (storageType == null ||
containerToSourceMap.containsKey(containerId)) {
+ toRemoveContainerIds.add(containerId);
+ }
Review Comment:
Handled in latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
