sreejasahithi commented on code in PR #11395: URL: https://github.com/apache/ozone/pull/11395#discussion_r4291303762
########## hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/volume/TestVolumeSetDiskChecks.java: ########## @@ -18,6 +18,7 @@ package org.apache.hadoop.ozone.container.common.volume; import static org.apache.commons.lang3.RandomStringUtils.secure; +import static org.apache.hadoop.hdds.protocol.datanode.proto.ContainerProtos.ContainerDataProto.State.RECOVERING; Review Comment: nit: you are already importing "org.apache.hadoop.hdds.protocol.datanode.proto.ContainerProtos.ContainerDataProto.State" , so we can drop this and use State.RECOVERING everywhere ########## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/ContainerSet.java: ########## Review Comment: nit: I think it would be better to update this javadoc aswell , as now it also calls removeRecoveringContainer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
