Copilot commented on code in PR #11569:
URL: https://github.com/apache/ozone/pull/11569#discussion_r4297348810
##########
hadoop-ozone/dev-support/checks/acceptance.sh:
##########
@@ -30,6 +30,8 @@ OZONE_ROOT=$(pwd -P)
if [[ "${OZONE_ACCEPTANCE_SUITE}" == "compat-old" ]]; then
: ${OZONE_OLD_VERSIONS:="${2:-}"}
export OZONE_OLD_VERSIONS
+else
+ export OZONE_AWS_CLI="${2:-}"
Review Comment:
This assignment both clears an environment-provided selector when `$2` is
absent and treats unrelated arguments as CLI selectors. For example,
`OZONE_AWS_CLI=aws2 acceptance.sh HA-unsecure` runs both CLIs. Conversely,
`check.yml:242` appends Ratis overrides, so an unsplit `misc` job can set this
variable to `-Dratis.version=...`; the helper interprets that as v1-only and
skips v2 for the vault tests. Preserve the environment value when no selector
is supplied, and only accept `aws` or `aws2` from the second argument.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
