andyhuangdev commented on code in PR #11562:
URL: https://github.com/apache/ozone/pull/11562#discussion_r4301761324
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/util/S3Utils.java:
##########
@@ -217,6 +217,13 @@ public static String validateSignatureHeader(HttpHeaders
headers, String resourc
throw ex;
}
+ if (!hasUnsignedPayload(xAmzContentSha256Header) &&
!hasMultiChunksPayload(xAmzContentSha256Header)
+ && !xAmzContentSha256Header.matches("[0-9a-fA-F]{64}")) {
Review Comment:
Agreed. I’ll normalize validated hex digests to lowercase in
validateSignatureHeader, preserving the unsigned and streaming constants, and
add upload tests for uppercase and mixed-case digests across regular,
datastream, and multipart uploads.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
