F64116045 commented on code in PR #11574:
URL: https://github.com/apache/ozone/pull/11574#discussion_r4302270138
##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java:
##########
@@ -3055,19 +3029,28 @@ public void recoverKey(OmKeyArgs args, long clientID)
throws IOException {
@Override
public Map<String, String> getObjectTagging(String volumeName, String
bucketName, String keyName)
throws IOException {
+ return getObjectTagging(volumeName, bucketName, keyName, false);
+ }
+
+ @Override
+ public Map<String, String> getObjectTagging(String volumeName,
+ String bucketName, String keyName, boolean assumeS3Context)
+ throws IOException {
if (!OzoneManagerVersion.S3_OBJECT_TAGGING_API.isSupportedBy(omVersion)) {
throw new IOException("OzoneManager does not support S3 object tagging
API");
}
- verifyVolumeName(volumeName);
+ if (!assumeS3Context) {
+ verifyVolumeName(volumeName);
+ }
verifyBucketName(bucketName);
Objects.requireNonNull(keyName, "keyName == null");
OmKeyArgs keyArgs = new OmKeyArgs.Builder()
.setVolumeName(volumeName)
.setBucketName(bucketName)
.setKeyName(keyName)
.build();
- return ozoneManagerClient.getObjectTagging(keyArgs);
+ return ozoneManagerClient.getObjectTagging(keyArgs, assumeS3Context);
Review Comment:
Thanks @Russole for working on this!
Should we add an OM version check for `assumeS3Context` and fall back to the
existing S3 volume lookup for older OMs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
