[
https://issues.apache.org/jira/browse/HDDS-17091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shuo Huang updated HDDS-17091:
------------------------------
Description:
TestStorageContainerManager#testCloseContainerCommandOnRestart has two issues:
* It may select an unhealthy container created by a failed write instead of the
container used by a committed key. ReplicationManager skips the unhealthy
container, causing the test to miss the expected close command.
* It contains two fixed 5-second sleeps, which add unnecessary execution time.
The original test failed once in 200 runs:
https://github.com/F64116045/ozone/actions/runs/39052240754
was:
testCloseContainerCommandOnRestart uses fixed sleeps while waiting for
ReplicationManager startup and container processing.
Wait for ReplicationManager#shouldRun instead. processAll() processes the
containers synchronously, so no additional wait is needed after it returns.
> Speed up TestStorageContainerManager#testCloseContainerCommandOnRestart
> -----------------------------------------------------------------------
>
> Key: HDDS-17091
> URL: https://issues.apache.org/jira/browse/HDDS-17091
> Project: Apache Ozone
> Issue Type: Sub-task
> Reporter: Shuo Huang
> Assignee: Shuo Huang
> Priority: Major
> Labels: pull-request-available
>
> TestStorageContainerManager#testCloseContainerCommandOnRestart has two issues:
>
> * It may select an unhealthy container created by a failed write instead of
> the container used by a committed key. ReplicationManager skips the unhealthy
> container, causing the test to miss the expected close command.
> * It contains two fixed 5-second sleeps, which add unnecessary execution time.
>
> The original test failed once in 200 runs:
> https://github.com/F64116045/ozone/actions/runs/39052240754
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
