smengcl opened a new pull request, #11630: URL: https://github.com/apache/ozone/pull/11630
Generated-by: Claude Code (Opus 5.5) ## What changes were proposed in this pull request? Ozone Manager accepts any client supplied string as the multipart upload ID. Upload IDs generated by OM have the form `<UUID>-<id>` and never contain `/`. This change adds `OMMultipartUploadUtils.validateUploadId`, which rejects upload IDs containing `/` with `NO_SUCH_MULTIPART_UPLOAD_ERROR` (S3 `NoSuchUpload`). It is called before any other processing in: - `preExecute` of `OMKeyCreateRequest` and `OMFileCreateRequest` (multipart part), `S3MultipartUploadCommitPartRequest`, `S3MultipartUploadCompleteRequest` and `S3MultipartUploadAbortRequest` - `OzoneManager.listParts` No protocol, version or layout change. Existing multipart uploads are not affected. ## What is the link to the Apache JIRA https://issues.apache.org/jira/browse/HDDS-17161 ## How was this patch tested? - New `testPreExecuteWithInvalidUploadId` in `TestS3MultipartUploadAbortRequest`, `TestS3MultipartUploadCommitPartRequest`, `TestS3MultipartUploadCompleteRequest`, `TestOMKeyCreateRequest` and `TestOMFileCreateRequest` (also run by their FSO subclasses), and `testInvalidUploadIdFailsWithoutKeyManager` in `TestOzoneManagerListPartsAcls`. Each fails without the corresponding call. - Existing tests in these classes pass locally. - CI on the fork: https://github.com/smengcl/hadoop-ozone/actions/runs/39319488872 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
