szetszwo commented on code in PR #11518: URL: https://github.com/apache/ozone/pull/11518#discussion_r4332596008
########## hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/ChunkReader.java: ########## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hdds.scm.storage; + +import java.io.IOException; +import java.nio.ByteBuffer; +import org.apache.hadoop.hdds.protocol.datanode.proto.ContainerProtos.ChunkInfo; +import org.apache.ratis.util.function.CheckedFunction; + +/** + * Reads checksum-aligned ranges without retaining a cursor or data buffers. + */ +final class ChunkReader { + private final ChunkInfo chunkInfo; + private final long length; Review Comment: Remove length field and use chunkInfo.getLen() (similar to chunkInfo.getOffset()) ########## hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/ChunkReader.java: ########## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hdds.scm.storage; + +import java.io.IOException; +import java.nio.ByteBuffer; +import org.apache.hadoop.hdds.protocol.datanode.proto.ContainerProtos.ChunkInfo; +import org.apache.ratis.util.function.CheckedFunction; + +/** + * Reads checksum-aligned ranges without retaining a cursor or data buffers. + */ +final class ChunkReader { + private final ChunkInfo chunkInfo; + private final long length; + private final boolean verifyChecksum; + private final CheckedFunction<ChunkInfo, ByteBuffer[], IOException> readChunk; Review Comment: Rename it to readChunkPositioned ########## hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/ChunkInputStream.java: ########## @@ -399,21 +393,7 @@ private synchronized void readChunkFromContainer(int len) throws IOException { } ChunkInfo getChunkInfo(long chunkRelativePosition, int toRead) { Review Comment: Remove this method and call reader.getChunkInfo(..) directly ```java //readChunkFromContainer final ChunkInfo adjustedChunkInfo = reader.getChunkInfo(startByteIndex, len); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
