ivandika3 commented on code in PR #10941:
URL: https://github.com/apache/ozone/pull/10941#discussion_r4333721087
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManagerHttpServer.java:
##########
@@ -33,7 +33,8 @@ public class OzoneManagerHttpServer extends BaseHttpServer {
public OzoneManagerHttpServer(MutableConfigurationSource conf,
OzoneManager om) throws IOException {
- super(conf, "ozoneManager");
+ super(conf, "ozoneManager", om == null ? null
+ : om.getOMServiceId() + '-' + om.getOMNodeId());
Review Comment:
> non-HA OM has a null service id,
Currently, `getOMNodeDetailsForNonHA` will set the service ID to
`omServiceIdDefault`.
> Node id is unique on its own:
It is possible to set multi-OM services to point to a single SCM service
where two OMs from each service have the same node ID, so the service ID + node
ID is useful to differentiate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
