[
https://issues.apache.org/jira/browse/HDDS-8376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wei-Chiu Chuang resolved HDDS-8376.
-----------------------------------
Resolution: Implemented
Resolving as implemented. SnapshotDiffManager now requests delta SST files for
exactly the table currently being processed using
Collections.singleton(fsTable.getName()). The table restriction is propagated
into both the RocksDB DAG differ and full-diff fallback, avoiding the original
directory-table/file-table cross-lookups.
Evidence at d0949f291791c399f3e54409fcb92656a80597a4:
*
https://github.com/apache/ozone/blob/d0949f291791c399f3e54409fcb92656a80597a4/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java#L1251
*
https://github.com/apache/ozone/blob/d0949f291791c399f3e54409fcb92656a80597a4/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/diff/delta/RDBDifferComputer.java#L73
*
https://github.com/apache/ozone/blob/d0949f291791c399f3e54409fcb92656a80597a4/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/diff/delta/FullDiffComputer.java#L115
> Optimize Snapdiff to not check for invalid object ids from rocksdb
> ------------------------------------------------------------------
>
> Key: HDDS-8376
> URL: https://issues.apache.org/jira/browse/HDDS-8376
> Project: Apache Ozone
> Issue Type: Sub-task
> Components: Snapshot
> Reporter: Swaminathan Balachandran
> Assignee: Swaminathan Balachandran
> Priority: Major
>
> Optimize Snapdiff code to not do invalid object id gets in case of
> FSOptimized table.
> Currently the getDeltaFiles returns all sst files corresponding to all the
> column families. In the case of FSOptimized bucket it has both directory
> table & file table. While computing snapdiff we look for directory table
> object ids in file tables & vice versa which is not going to return any
> result anyhow. We can avoid this check, by identifying the column family sst
> file belongs to from the table properties in the sst file meta info.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
