chungen0126 commented on code in PR #11643:
URL: https://github.com/apache/ozone/pull/11643#discussion_r4344526978
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/node/TestDecommissionAndMaintenance.java:
##########
@@ -242,7 +242,7 @@ public void
testNodeWithOpenPipelineCanBeDecommissionedAndRecommissioned()
scmClient.recommissionNodes(Arrays.asList(
getDNHostAndPort(toDecommission)));
waitForDnToReachOpState(nm, toDecommission, IN_SERVICE);
- waitForDnToReachPersistedOpState(toDecommission, IN_SERVICE);
+ waitForDnToReachPersistedOpState(nm.getNode(dnID), IN_SERVICE);
Review Comment:
Should we replace all of `toDecommission` here with` newDn` as well to
ensure we are referencing the updated node instance after the restart?
```
DatanodeDetails newDn = nm.getNode(dnID);
scmClient.recommissionNodes(Arrays.asList(getDNHostAndPort(newDn)));
waitForDnToReachOpState(nm, newDn, IN_SERVICE);
waitForDnToReachPersistedOpState(newDn, IN_SERVICE);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
