anuragp010 commented on code in PR #11626:
URL: https://github.com/apache/ozone/pull/11626#discussion_r4347427554
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRequest.java:
##########
@@ -1210,9 +1209,11 @@ private OmKeyInfo prepareMultipartFileInfo(
}
// For this upload part we don't need to check in KeyTable. As this
// is not an actual key, it is a part of the key.
+ // The part takes the storage policy of the multipart key, not the one in
args: the client
+ // does not send it when opening a part, and allocateBlock later sends the
policy of this part.
Review Comment:
@Gargi-jais11 , @devmadhuu Yes, `OMAllocateBlockRequest` would allocate the
block in the changed bucket policy (`WARM`) diverging from the MPU Key's
initial policy of `COLD`. This can be handled by retrieving the storagePolicy
of from the `openKeyTable` during `OMAllocateBlockRequest#preExecute` if the
passed storagePolicy is `null`.
This scenario while more prominent with MPU, would apply to a normal key's
`allocateBlock` path as well. Would you recommend fixing this as part of the
same PR or should I create a follow up JIRA for the same?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
