[ 
https://issues.apache.org/jira/browse/HDDS-8082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18130485#comment-18130485
 ] 

Siyao Meng commented on HDDS-8082:
----------------------------------

[Jira cleanup 2026-10-22] Resolving as Implemented. The requested 
config-default newline regression check exists.

Evidence:
* https://github.com/apache/ozone/pull/10840
* 
https://github.com/apache/ozone/commit/5672fc71c5d74dd3947f43a94cdbb3a587217750
* 
https://github.com/apache/ozone/blob/bf3829e6c8ac69ae17585585703f91426dcdf6b3/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestOzoneConfigurationFields.java#L106

Feel free to reopen if further work is needed.

> Check for unnecessary newlines in config defaults
> -------------------------------------------------
>
>                 Key: HDDS-8082
>                 URL: https://issues.apache.org/jira/browse/HDDS-8082
>             Project: Apache Ozone
>          Issue Type: Improvement
>          Components: test
>            Reporter: Attila Doroszlai
>            Assignee: Chia-Yi Chiu
>            Priority: Major
>              Labels: GoodForNewContributors, pull-request-available
>
> HDDS-8046 removed some unnecessary newlines embedded in default config values 
> in {{ozone-default.xml}}.  [~ayushtkn] had a great suggestion for avoiding 
> these in the future:
> bq. I thought of adding a test, which checks for all the configs - set of 
> configs added into the exception list and warns like don't add such breaks 
> unnecessarily, if it is important and legitimate then add it into the 
> exception list, that way even the reviewer would be aware that this practice 
> isn't encouraged.



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to