smengcl commented on code in PR #11683:
URL: https://github.com/apache/ozone/pull/11683#discussion_r4364637611


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRequest.java:
##########
@@ -156,6 +156,7 @@ protected KeyArgs resolveBucketLink(
   protected KeyArgs resolveBucketAndCheckKeyAcls(KeyArgs keyArgs,
       OzoneManager ozoneManager, IAccessAuthorizer.ACLType aclType)
       throws IOException {
+    toOzoneAcls(keyArgs.getAclsList());
     KeyArgs resolvedArgs = resolveBucketLink(ozoneManager, keyArgs);
     // check Acl
     checkKeyAcls(ozoneManager, resolvedArgs.getVolumeName(),

Review Comment:
   Addressed in 8f81010be23, 73cf3abde29, 3deca459d29 and 753b242ea94: with 
`ozone.om.object.creation.ignore.client.acls=true`, key, bucket and volume 
create requests now skip the client ACLs instead of validating them, and 
`testInvalidAcl` covers both settings.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to