[
https://issues.apache.org/jira/browse/HDDS-17456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HDDS-17456:
----------------------------------
Labels: pull-request-available (was: )
> Remove the test-only BlockInputStream constructor
> -------------------------------------------------
>
> Key: HDDS-17456
> URL: https://issues.apache.org/jira/browse/HDDS-17456
> Project: Apache Ozone
> Issue Type: Improvement
> Reporter: Andy Huang
> Assignee: Andy Huang
> Priority: Trivial
> Labels: pull-request-available
>
> Follow-up to the constructor cleanup review comment on HDDS-17206:
> https://github.com/apache/ozone/pull/11660#discussion_r4343949881
> BlockInputStream has a constructor taking BlockID and length that is marked
> as only for unit tests. Its sole direct caller is TestChunkStreams; the other
> callers already use the BlockLocationInfo constructor.
> Remove the test-only constructor and update TestChunkStreams to build
> BlockLocationInfo and call the remaining constructor. This follows the same
> cleanup made for StreamBlockInputStream in HDDS-17206 and preserves the
> existing test behavior.
> Validation: TestBlockInputStream and TestChunkStreams passed (19 tests
> total), along with Checkstyle for hdds-client and ozone-manager and git diff
> --check.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
