chihsuan commented on code in PR #11722: URL: https://github.com/apache/ozone/pull/11722#discussion_r4373706679
########## dev-support/ci/acceptance_suites.sh: ########## @@ -19,9 +19,11 @@ # shellcheck source=dev-support/ci/lib/_script_init.sh . dev-support/ci/lib/_script_init.sh -SUITES=$(grep --no-filename -r '^#suite:' hadoop-ozone/dist/src/main/compose \ - | sort -u | cut -f2 -d':' | grep -v 'failing') -VERSIONS=$(grep '^old_versions=' hadoop-ozone/dist/src/main/compose/xcompat/lib.sh \ +cd hadoop-ozone/dist/src/main/compose +SUITES=$(find . -mindepth 2 -maxdepth 2 -name 'test*.sh' | cut -c3- \ Review Comment: I found that `ozone/test.sh` would also match `ozone/test-short-circuit.sh` in [`find_tests`](https://github.com/apache/ozone/blob/243352604abac44ea1304788730fb7bbe52102d9/hadoop-ozone/dist/src/main/compose/testlib.sh#L105), so short-circuit runs twice. Would an exact match make sense here? ########## hadoop-ozone/dev-support/checks/acceptance.sh: ########## @@ -56,7 +56,7 @@ create_aws_dir mkdir -p "$REPORT_DIR" -if [[ "${OZONE_ACCEPTANCE_SUITE}" == "s3a" ]]; then +if [[ "${OZONE_TEST_SELECTOR}" =~ "test-s3a.sh" ]]; then Review Comment: nit: Just to confirm, is it expected that `repeat-acceptance.yml` with suite `s3a` no longer triggers the S3A setup? Or should we still support it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
