Gargi-jais11 commented on code in PR #11743:
URL: https://github.com/apache/ozone/pull/11743#discussion_r4376212287
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/TestXceiverServerDomainSocket.java:
##########
@@ -623,6 +624,12 @@ public void testMaxXceiverCount() throws IOException,
InterruptedException {
}
lastSock.close();
assertFalse(lastSock.isOpen());
+
+ // the rejected connection must not hold a slot once every accepted
connection is closed
+ list.get(count - 2).close();
Review Comment:
I agree, changing the earlier loop to` i <= count - 2` would close all 50
accepted connections in one place and also removes the separate` list.get(count
- 2).close()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
