devmadhuu commented on PR #11685: URL: https://github.com/apache/ozone/pull/11685#issuecomment-6419896054
@lpavanvenkat largely changes looks fine, just one comment and a nit. Could we handle older FSO multipart open-key records whose keyName contains only the filename? Before [HDDS-10649](https://issues.apache.org/jira/browse/HDDS-10649), the open-file write path stored the leaf name. For an unfinished upload of `dir/test1.txt`, this lookup therefore constructs `/vol/bucket/test1.txt/uploadId`, while the multipart info entry is under `/vol/bucket/dir/test1.txt/uploadId`. The lookup returns null and reports zero despite committed parts being present. The new FSO test uses the full `dir/mpu-legacy` name, so it does not cover this older record format. Could we resolve the full key path for these records and add a test? If support is intentionally deferred, please document this additional limitation and track the follow-up. One optional test suggestion: cover erasure-coded uploads. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
