adoroszlai commented on code in PR #11773:
URL: https://github.com/apache/ozone/pull/11773#discussion_r4381311254
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/ContainerScannerConfiguration.java:
##########
@@ -75,15 +75,15 @@ public class ContainerScannerConfiguration {
description = "Config parameter to enable all container scanners.")
private boolean enabled = true;
- @Config(key = "hdds.container.scrub.dev.data.scan.enabled",
+ @Config(key = HDDS_CONTAINER_SCRUB_DEV_DATA_ENABLED,
Review Comment:
Instead of using the constants to define `@Config(key)`, I suggest:
- keep string key
- add mutators (`set...` methods)
- set config in "real" test using this pattern:
https://github.com/apache/ozone/blob/da33da1c828c02c1a6cc210fe35f02e52bb461c7/hadoop-ozone/integration-test/src/test/java/org/apache/ozone/test/ClusterForTests.java#L57-L61
- drop changes in `TestContainerScannerConfiguration` that just verify
config plumbing
- delete the constants
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
