sravani-revuri commented on code in PR #11772:
URL: https://github.com/apache/ozone/pull/11772#discussion_r4386014029
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/tagging/S3DeleteObjectTaggingRequest.java:
##########
@@ -76,8 +77,19 @@ public OMRequest preExecute(OzoneManager ozoneManager)
throws IOException {
keyArgs.toBuilder()
.setKeyName(keyPath);
- KeyArgs resolvedArgs = resolveBucketAndCheckKeyAcls(newKeyArgs.build(),
- ozoneManager, ACLType.WRITE);
+ KeyArgs requestedArgs = newKeyArgs.build();
Review Comment:
currently , i think with the single catch (IOException), if
resolveBucketLink throws (e.g. BUCKET_NOT_FOUND), we still call markForAudit, i
don't see similar behaviour for Bucket Tagging , is this intended?
if not, can we mirror S3BucketTaggingRequestBase.preExecute with the
resolveBucketLink outside the try catch and and wrap the checkKeyAcls in an if
block?
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/tagging/S3PutObjectTaggingRequest.java:
##########
@@ -76,8 +77,19 @@ public OMRequest preExecute(OzoneManager ozoneManager)
throws IOException {
keyArgs.toBuilder()
.setKeyName(keyPath);
- KeyArgs resolvedArgs = resolveBucketAndCheckKeyAcls(newKeyArgs.build(),
- ozoneManager, ACLType.WRITE);
+ KeyArgs requestedArgs = newKeyArgs.build();
Review Comment:
same here as DeleteObjectTaggingRequest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
