aayush2761 commented on code in PR #11759:
URL: https://github.com/apache/ozone/pull/11759#discussion_r4393348833
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRenameRequest.java:
##########
@@ -89,8 +89,25 @@ public OMRequest preExecute(OzoneManager ozoneManager)
throws IOException {
KeyArgs.Builder newKeyArgs = renameKeyArgs.toBuilder()
.setModificationTime(Time.now()).setKeyName(srcKey);
- KeyArgs resolvedArgs = resolveBucketAndCheckAcls(newKeyArgs.build(),
- ozoneManager, srcKey, dstKey);
+ KeyArgs auditArgs = newKeyArgs.build();
+ try {
+ auditArgs = resolveBucketLink(ozoneManager, auditArgs);
+ } catch (IOException ignored) {
+ }
+
+ KeyArgs resolvedArgs;
+ try {
+ resolvedArgs = resolveBucketAndCheckAcls(newKeyArgs.build(),
+ ozoneManager, srcKey, dstKey);
+ } catch (IOException ex) {
+ // Ensure audit log captures preExecute failures
+ markForAudit(ozoneManager.getAuditLogger(),
+ buildAuditMessage(OMAction.RENAME_KEY,
+ buildAuditMap(auditArgs,
+ renameKeyRequest.toBuilder().setToKeyName(dstKey).build()),
+ ex, getOmRequest().getUserInfo()));
+ throw ex;
+ }
Review Comment:
addressed, Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
