smengcl commented on code in PR #11788:
URL: https://github.com/apache/ozone/pull/11788#discussion_r4385157029
##########
hadoop-ozone/dist/src/main/smoketest/s3/objectputget.robot:
##########
@@ -337,3 +337,22 @@ Put object with wrong Content-MD5 header
${result} = Execute AWSS3APICli and checkrc head-object
--bucket ${BUCKET} --key ${PREFIX}/putobject/md5test/key2 255
Should contain ${result} 404
+
+Put object with server-side encryption
Review Comment:
nit: both new test cases assert Ozone specific behavior (`NotImplemented`
for SSE on a regular bucket and for SSE-C), so they will fail when this suite
is run against AWS with `s3_compatbility_check.sh`, which runs
`objectputget.robot` and only excludes `aws-skip`. Consider tagging them the
same way as the Ozone only cases in `bucketcreate.robot`:
```diff
Put object with server-side encryption
+ [tags] aws-skip
Execute echo "sse" >
/tmp/ssetestfile
@@
Put object with customer-provided encryption key
+ [tags] aws-skip
Execute echo "ssec" >
/tmp/ssectestfile
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
