devmadhuu commented on PR #11647: URL: https://github.com/apache/ozone/pull/11647#issuecomment-6458053020
> > if updateDetails for updating task status gets failed to update or insert in RECON_TASK_STATUS table, then should we atleast update the relevant sync metric for success and failure ? > > Thanks @devmadhuu for the review. The OM sync success and failure metrics (`OzoneManagerSyncMetrics`, `ReconSyncMetrics`, `ReconTaskMetrics`) are in-memory counters updated by the sync code itself, not read from `RECON_TASK_STATUS`, so they stay correct when the status write fails. > > This patch makes them more accurate. Before, a failed status write after a successful delta sync was counted as a delta failure and triggered a full snapshot request. > > What can be out of date after a failed write is the `RECON_TASK_STATUS` row itself, which `ReconTaskStatusMetrics` and the task status API read, until the next successful write for that task. > > > May be you want to do in follow up PR or in this ? > > Yes, a counter for task status write failures would make that visible. Since it needs a metrics source wired into `ReconTaskStatusUpdater`, I filed HDDS-17512 as a follow-up. Sound Good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
