ChenSammi commented on PR #11721: URL: https://github.com/apache/ozone/pull/11721#issuecomment-6459578418
Thanks @priyeshkaratha for updating the patch. One minor comment is we'd better change the log message from "KeyLifecycleService is suspended, disabled, or leader not ready" to ""KeyLifecycleService is suspended, disabled, leader not ready, or about to restart". And the introduced "OZONE_KEY_LIFECYCLE_PROPERTIES" reminds me that maybe we should extract all the key lifecycle properties from OMConfigKeys, to a new file, similar to "OmConfig", and extend the ReconfigurableConfig. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
