adoroszlai commented on code in PR #11806:
URL: https://github.com/apache/ozone/pull/11806#discussion_r4397434732
##########
.github/workflows/check.yml:
##########
@@ -196,6 +196,24 @@ jobs:
restore-keys: |
maven-repo-
+ # Hard-coded for the acceptance suites that download Apache releases, to
avoid the need for another input.
+ - name: Get versions of Apache releases used by tests
+ id: apache-release-versions
+ if: ${{ inputs.script == 'acceptance' && (inputs.split == 'ranger' ||
inputs.split == 's3a') }}
+ run: |
+ hadoop=$(sed -n 's@.*<hadoop.version>\(.*\)</hadoop.version>.*@\1@p'
pom.xml)
+ ranger=$(sed -n 's@.*<ranger.version>\(.*\)</ranger.version>.*@\1@p'
pom.xml)
+ echo "versions=hadoop-${hadoop}-ranger-${ranger}" >> "$GITHUB_OUTPUT"
+
+ - name: Cache for Apache releases used by tests
+ if: ${{ steps.apache-release-versions.outcome == 'success' }}
+ uses: actions/cache@v6
+ with:
+ path: |
+ /tmp/*ranger-*.tar.gz*
+ target/hadoop-src.tar.gz
+ key: apache-releases-${{ inputs.split }}-${{
steps.apache-release-versions.outputs.versions }}
+
Review Comment:
Please don't add this now.
1. Avoid hard-coding in a generic check.
2. The CI workflow should just restore cache, not write it ()
3. These artifacts come from separate tests, each only needs one of them.
4. Total cache size per repo is limited
I plan to migrate from reusable workflow to a proper action (HDDS-17509) and
use stash (HDDS-17211) to avoid these problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
