jojochuang commented on PR #11674: URL: https://github.com/apache/ozone/pull/11674#issuecomment-6477231365
The integration (client) failure is caused by the newly added OM version exposing an equality check in `TestRpcClient.testIfNoneMatchETagReachesOMOrRejectsOldVersion`. The test currently expects If-None-Match support only when `version == S3_IF_NONE_MATCH_ETAG` (104). Production `RpcClient.checkIfNoneMatchETagSupport()` correctly accepts 104 and later. With this PR's `RENAME_KEY_REJECTS_NON_FSO` (105), the three requests therefore reach the mock OM, but the test incorrectly expects an empty request list at line 695. The fix is to use `version.compareTo(OzoneManagerVersion.S3_IF_NONE_MATCH_ETAG) >= 0` in the test, matching the production capability check. This also handles future OM versions. I pushed the one-line fix on top of this PR's head to my fork: https://github.com/jojochuang/ozone/commit/f6cfeb8462ad439f6ba0992bfed25008c946a512 (branch `codex/hdds-16951-ci-fix`). Feel free to cherry-pick it. Validation: `git diff --check` passes. I attempted the targeted parameterized test on JDK 21, but compilation stopped before tests because local Ozone snapshot dependencies are stale (missing `setExcludedETag` and `setRequireFileSystemOptimized`); I have not verified a passing local test run. The integration (ozone) failure is different: `TestBackgroundContainerDataScannerIntegration` reports an `RDBMetrics` source still registered after shutdown. I found no evidence linking that failure to the rename change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
