rjgoyln opened a new pull request, #11828:
URL: https://github.com/apache/ozone/pull/11828

   ## What changes were proposed in this pull request?
   
   `OpenKeyCleanupService` commits an hsync'ed key past 
`ozone.om.lease.hard.limit` by submitting `CommitKey` straight to Ratis, which 
skips `OMKeyCommitRequest.preExecute`, where a commit gets its modification 
time. The key is stored with modification time 0, so `getKeyInfo` reports 
1970-01-01 and a days-based lifecycle expiration rule matches it at once.
   
   Setting the time before the request enters Ratis keeps it the same on every 
OM. Running the full `preExecute`, as `KeyLifecycleService` does, would also 
put a write ACL check under the OM's own user on this internal request.
   
   ## What is the link to the Apache JIRA?
   
   https://issues.apache.org/jira/browse/HDDS-16847
   
   ## How was this patch tested?
   
   - `testCommitExpiredHsyncKeys` now checks the committed keys' modification 
time; it fails on master with all 10 keys at 0.
   - The JIRA's reproduction, which asserts the bug, passes on master for FSO 
and OBS buckets and fails with this patch.
   - Related OM unit tests (90), `TestHSync` (43), checkstyle and PMD pass.
   
   Generated-by: Claude Code (Opus 5.5)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to