jojochuang commented on PR #11824: URL: https://github.com/apache/ozone/pull/11824#issuecomment-6473388476
The PR addresses a valid issue. There are two different retry mechanisms: - RPC retries: fetching the key can retry/fail over, but eventually return an exception. - Periodic polling: checkAndRefresh() itself has no retry loop. It wraps an IOException in UncheckedIOException. Before this patch, that exception escapes the scheduled task, which permanently suppresses subsequent polls—it doesn’t try again 10 minutes later. That is specified by [Java’s scheduler contract](https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/util/concurrent/ScheduledExecutorService.html#scheduleAtFixedRate(java.lang.Runnable,long,long,java.util.concurrent.TimeUnit)). - Looks good. Let's see what copilot says. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
