Gargi-jais11 opened a new pull request, #11835:
URL: https://github.com/apache/ozone/pull/11835

   ## What changes were proposed in this pull request?
   There are two problems in `XceiverClientShortCircuit` when a caller gives up 
on a short-circuit GetBlock:
   
   - **NPE on interrupt**. If the reading thread is interrupted while waiting 
for the response, sendCommandWithTraceID records neither a response nor an 
exception. `Objects.requireNonNull(ioException)` then throws a NPE, which skips 
the gRPC fallback in BlockInputStream.
   - **Leaked descriptor.** The datanode still answers the request, and the 
client caches the block file stream it receives. Nobody ever claims that 
stream, so the file descriptor stays open for the life of the client process. 
The same happens when a validator rejects a successful response.
   
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-17441
   
   ## How was this patch tested?
   
   Added 
`TestXceiverServerDomainSocket#testClientReleasesStreamOfAbandonedRequest`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to