ChenSammi commented on code in PR #11798:
URL: https://github.com/apache/ozone/pull/11798#discussion_r4408658908
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/XceiverServerDomainSocket.java:
##########
@@ -230,6 +230,14 @@ public void run() {
// usually when the xceiver count limit is hit.
LOG.warn("Got an exception. Peer {}", peer, ie);
IOUtils.closeQuietly(peer);
+ if (peer == null) {
+ // accept() itself failed, for example with no file descriptor left,
and would fail again right away
+ try {
+ Thread.sleep(TimeUnit.SECONDS.toMillis(1L));
Review Comment:
I prefer the current fixed 1s, since it 's only to avoid bursting messages
to the DN log file in case of DN run out of file descriptors, so I don't expect
it will happen frequently, and when it happens, user is expected to tune the
file descriptors or investigate whether there is FD leaks, instead of tuning
this sleep interval.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
