errose28 commented on code in PR #11692:
URL: https://github.com/apache/ozone/pull/11692#discussion_r4416885823
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/server/TestSCMDatanodeHeartbeatDispatcher.java:
##########
@@ -166,6 +175,84 @@ public void testVersionReportProcessedOnlyWhenPresent()
throws IOException {
verify(mockNodeManager, times(1)).processVersionReport(any(), any());
}
+ private static Stream<NodeStatus> unhealthyNodeStatuses() {
+ return Stream.of(NodeStatus.inServiceStale(), NodeStatus.inServiceDead());
+ }
+
+ @Test
+ public void testHealthyNodeWithVersionReportIsNeverFenced() throws Exception
{
Review Comment:
This test trivially passes regardless of the node status because
`MockNodeManager#shouldFenceDatanode` always returns `false`. It needs to be
mocked to return `true` to ensure that the status is actually what caused the
node to be let through.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
