smengcl commented on PR #11780: URL: https://github.com/apache/ozone/pull/11780#issuecomment-6510372521
Thanks, added all three as cases of `testCommittedKeyTableMatchesCache`, plus `a -> b`, `c -> a`, `a -> d`. `a -> b`, `a -> c` alone does not replace the response map entry: the second pair finds `a` already deleted in the cache and is reported as not renamed. The entry is replaced only when `a` is recreated in between, as in the added case. Without the fix that case and the first two existing ones leave the DB different from the cache; the repeated source, repeated destination and nonadjacent cases commit correctly and fail only on the missing rejection. The partial rename case is the new `testPairsSharingKeyRejectedInsteadOfPartialRename`: `preExecute` rejects `b -> c`, `a -> b` with `INVALID_REQUEST`, and the same request applied by `validateAndUpdateCache` alone still ends in `PARTIAL_RENAME` with `a` renamed to `b`. The description now states the change from partial success to rejecting the whole request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
