fmorg-git commented on code in PR #11810:
URL: https://github.com/apache/ozone/pull/11810#discussion_r4419648075
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/security/S3DeleteRevokedSTSTokensRequest.java:
##########
@@ -64,7 +76,44 @@ public OMClientResponse validateAndUpdateCache(OzoneManager
ozoneManager, Execut
final OMResponse.Builder omResponse =
OmResponseUtil.getOMResponseBuilder(getOmRequest());
final List<String> originalAccessKeyIds =
request.getOriginalAccessKeyIdList();
- return new S3DeleteRevokedSTSTokensResponse(originalAccessKeyIds,
omResponse.build());
+ final List<Long> revocationTimeMillisList =
request.getRevocationTimeMillisList();
+ final Table<String, Long> table =
ozoneManager.getMetadataManager().getS3RevokedStsTokenTable();
+ final List<String> deletedIds;
+ try {
+ if (revocationTimeMillisList.isEmpty()) {
Review Comment:
discussed internally
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/RevokedSTSTokenCleanupService.java:
##########
@@ -136,8 +145,13 @@ public BackgroundTaskResult call() throws Exception {
// Read the metadata manager on every run, since installing a checkpoint
replaces it
final Table<String, Long> revokedStsTokenTable =
ozoneManager.getMetadataManager().getS3RevokedStsTokenTable();
- long deletedInRun = 0;
+ // This is called submittedInRun because the submitted
originalAccessKeyId and revocationTimeCutoffMillis pair
+ // might not actually get deleted if at time of deletion the
revocationTimeCutoffMillis was updated to a later
+ // value
+ long submittedInRun = 0;
Review Comment:
discussed internally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
