jojochuang commented on code in PR #11706:
URL: https://github.com/apache/ozone/pull/11706#discussion_r4419098619
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/utils/ContainerCache.java:
##########
@@ -81,24 +83,30 @@ public static synchronized ContainerCache getInstance(
}
/**
- * Closes all the db instances and resets the cache.
+ * Closes and removes all the db instances that are not in use.
*/
public void shutdownCache() {
+ List<String> inUse = new ArrayList<>();
lock.lock();
try {
// iterate the cache and close each db
MapIterator iterator = cache.mapIterator();
while (iterator.hasNext()) {
iterator.next();
ReferenceCountedDB db = (ReferenceCountedDB) iterator.getValue();
- Preconditions.checkArgument(cleanupDb(db), "refCount: %s",
- db.getReferenceCount());
+ if (cleanupDb(db)) {
+ iterator.remove();
+ } else {
+ // Still referenced: leave it open for its user; it is closed once
released and evicted or removed.
Review Comment:
Could you clarify the production cleanup path for a DB retained here?
ReferenceCountedDB.close() only decrements the reference count; releasing the
last handle does not itself close the store. The new test demonstrates eventual
closure by calling shutdownCache() a second time, but that is an explicit retry
rather than automatic cleanup. If shutdownCache() is called only once and no
later eviction/removal happens, the DB remains open after its user finishes.
Please clarify whether that lifetime is intentional, and whether the shutdown
caller guarantees a later cleanup pass. This applies to the schema-v1/v2
ContainerCache path; schema v3 uses the separate shared-store cache.
Generated-by: Codex (GPT-6)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
