sravani-revuri commented on code in PR #11827:
URL: https://github.com/apache/ozone/pull/11827#discussion_r4420430997
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/balancer/TestContainerBalancer.java:
##########
@@ -290,6 +290,8 @@ public void testDelayedStartOnSCMStatusChange()
() -> balancingThread.getState() == Thread.State.TIMED_WAITING, 2, 20);
assertThat(logCapturer.getOutput()).contains(expectedLog);
stopBalancer();
+ assertThat(logCapturer.getOutput()).contains("Container Balancer was
interrupted during the delayed start.");
+ assertThat(logCapturer.getOutput()).doesNotContain("Container Balancer is
stopped abnormally");
Review Comment:
Overall LGTM.
minor nit:
after stopBalancer(), you could also assert stop reason and stop message on
getBalancerStatusInfo() (same as testGetBalancerStatusInfoAfterUserStop).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
