szetszwo commented on PR #9472: URL: https://github.com/apache/ozone/pull/9472#issuecomment-6528798209
> ReplicationManagerReport.HealthState Could you point out the code? I cannot find the HealthState class. > ContainerHealthResult.HealthState represented ... We should redesign ContainerHealthResult. HEALTHY and UNHEALTHY are ill-defined states. > QUASI_CLOSED already exists in HddsProtos.LifeCycleState You are right that we should reuse LifeCycleState. Then, we don't need "Open/close: OPEN_WITH_PIPELINE, OPEN_WITHOUT_PIPELINE, CLOSE, QUASI_CLOSED". We could have a - Pipeline: HAS_PIPELINE, NO_PIPELINE Your suggestion sounds great! Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
