F64116045 commented on code in PR #11809:
URL: https://github.com/apache/ozone/pull/11809#discussion_r4427066854
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeDecommissionManager.java:
##########
@@ -422,7 +422,7 @@ private synchronized boolean
checkIfDecommissionPossible(List<DatanodeDetails> d
continue;
}
int reqNodes = cif.getReplicationConfig().getRequiredNodes();
- if ((inServiceTotal - numDecom) < reqNodes) {
+ if ((inServiceTotal - healthyNodesToDecommission) < reqNodes) {
final int unHealthyTotal = nodeManager.getAllNodeCount() -
inServiceTotal;
String errorMsg = "Insufficient nodes. Tried to decommission " +
dns.size() +
Review Comment:
Thanks for the suggestion, added.
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeDecommissionManager.java:
##########
@@ -589,7 +589,7 @@ private synchronized boolean
checkIfMaintenancePossible(List<DatanodeDetails> dn
} else {
minInService = maintenanceReplicaMinimum;
}
- if ((inServiceTotal - numMaintenance) < minInService) {
+ if ((inServiceTotal - healthyNodesEnteringMaintenance) <
minInService) {
final int unHealthyTotal = nodeManager.getAllNodeCount() -
inServiceTotal;
String errorMsg = "Insufficient nodes. Tried to start maintenance
for " + dns.size() +
Review Comment:
Thanks for the suggestion, added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
