[
https://issues.apache.org/jira/browse/HDDS-5503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ethan Rose resolved HDDS-5503.
------------------------------
Fix Version/s: 1.2.0
Resolution: Fixed
> On finalize upgrade actions not running
> ---------------------------------------
>
> Key: HDDS-5503
> URL: https://issues.apache.org/jira/browse/HDDS-5503
> Project: Apache Ozone
> Issue Type: Sub-task
> Components: Ozone Datanode
> Reporter: Ethan Rose
> Assignee: Mark Gui
> Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.2.0
>
>
> When running TestHDDSUpgrade integration tests, we can see the following log
> messages indicating the upgrade actions were registered:
> {code:java}
> INFO upgrade.HDDSLayoutVersionManager
> (HDDSLayoutVersionManager.java:lambda$registerUpgradeActions$0(76)) -
> Registering Upgrade Action : ScmHAFirstUpgradeLayoutChangeAction
> INFO upgrade.HDDSLayoutVersionManager
> (HDDSLayoutVersionManager.java:lambda$registerUpgradeActions$0(76)) -
> Registering Upgrade Action : ScmHAUnfinalizedStateValidationAction
> INFO upgrade.HDDSLayoutVersionManager
> (HDDSLayoutVersionManager.java:lambda$registerUpgradeActions$0(76)) -
> Registering Upgrade Action : ScmOnFinalizeActionForDatanodeSchemaV2
> INFO upgrade.HDDSLayoutVersionManager
> (HDDSLayoutVersionManager.java:lambda$registerUpgradeActions$0(76)) -
> Registering Upgrade Action : DatanodeSchemaV2FinalizeAction{code}
> (Side note, we may want to come up with a naming convention for these so it's
> easier to tell what is what)
> The logs do not show the messages for the on finalize actions for schema V2
> on either the datanode or SCM, indicating they are not actually being run.
> Currently both these operations are no-ops so no breaking behavior was
> noticed. We do not yet have any on finalize actions that do real work.
> The testing for upgrade actions registering and running uses a fair amount of
> mocking, which may miss cases that come up for the actual upgrade actions. We
> should verify that all upgrade actions get registered and run correctly as
> part of this Jira, and maybe implement more robust testing.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
