errose28 commented on code in PR #11861:
URL: https://github.com/apache/ozone/pull/11861#discussion_r4475101334
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/pipeline/TestWritableRatisContainerProvider.java:
##########
@@ -84,6 +84,41 @@ void returnsExistingContainer() throws Exception {
verifyPipelineNotCreated();
}
+ @RepeatedTest(100)
Review Comment:
Was this left over from debugging, or do want to do 100 runs every time? I
see this annotation on other committed tests here already.
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/WritableECContainerProvider.java:
##########
Review Comment:
It looks like there are differences between the Ratis and EC providers'
handling. Things like how frequently they log about pipelines with unregistered
nodes and how they count the unregistered pipelines towards the pipeline limit.
I'm still working out a way to reconcile these, but feel free to take a stab at
it as well.
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMClientProtocolServer.java:
##########
@@ -328,6 +328,12 @@ private ContainerWithPipeline
getContainerWithPipelineCommon(
pipeline = null;
}
+ // An OPEN pipeline reloaded from the SCM DB can list datanodes that have
not registered since SCM started.
Review Comment:
```suggestion
// A pipeline reloaded from the SCM DB can list datanodes that have not
registered since SCM started.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
