szetszwo commented on code in PR #11801:
URL: https://github.com/apache/ozone/pull/11801#discussion_r4462272955
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ScmRatisServerConfig.java:
##########
@@ -42,11 +42,30 @@ public class ScmRatisServerConfig {
)
private long logAppenderWaitTimeMin;
+ /** @see RaftServerConfigKeys.Log#APPEND_ENTRIES_COMPOSE_ENABLED_KEY */
+ @Config(key = "ozone.scm.ha.raft.server.log.append-entries.compose.enabled",
+ defaultValue = "false",
+ type = ConfigType.BOOLEAN,
+ tags = {OZONE, SCM, RATIS, PERFORMANCE},
+ description = "Whether a follower composes the log append of an
appendEntries request with the " +
+ "in-flight appends of earlier requests, so that it can accept a
request before the previous " +
+ "entries are written to the Raft log."
+ )
+ private boolean appendEntriesComposeEnabled;
+
public long getLogAppenderWaitTimeMin() {
return logAppenderWaitTimeMin;
}
Review Comment:
During reviewing this PR, found that getLogAppenderWaitTimeMin() was never
called. So, the logAppenderWaitTimeMin seems unused.
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/ha/TestSCMConfiguration.java:
##########
@@ -214,6 +216,14 @@ public void testSCMConfig() throws Exception {
final TimeDuration t = RaftServerConfigKeys.Log.Appender.waitTimeMin(p);
assertEquals(TimeDuration.ZERO, t,
RaftServerConfigKeys.Log.Appender.WAIT_TIME_MIN_KEY);
Review Comment:
When running this test locally, it actually will fail. Not sure why it does
not fail in the PR builds. Cc @adoroszlai
```
rg.opentest4j.AssertionFailedError: raft.server.log.appender.wait-time.min
==>
Expected :0ns
Actual :1ms
<Click to see difference>
at
org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
at
org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
at
org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
at
org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1156)
at
org.apache.hadoop.hdds.scm.ha.TestSCMConfiguration.testSCMConfig(TestSCMConfiguration.java:215)
at java.base/java.lang.reflect.Method.invoke(Method.java:565)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1612)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
