chihsuan commented on code in PR #11740:
URL: https://github.com/apache/ozone/pull/11740#discussion_r4504824052


##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/S3RequestContext.java:
##########
@@ -57,6 +57,14 @@ OzoneVolume getVolume() throws IOException {
     return volume;
   }
 
+  /** Returns the cached volume name without an OM call, or null if it has not 
been looked up. */
+  String getResolvedVolumeName() {

Review Comment:
   nit: Could we rename this to something like `getVolumeNameIfLookedUp()` or 
`getCachedVolumeName()` to distinguish it from `getVolumeName()`?   This method 
only returns the volume cached in the request context.  “Resolved” could also 
be confused with bucket-link resolution.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to