chungen0126 commented on code in PR #11889:
URL: https://github.com/apache/ozone/pull/11889#discussion_r4506935783


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRenameRequestWithFSO.java:
##########
@@ -258,6 +258,18 @@ private PreparedRename prepareRename(OzoneManager 
ozoneManager, RenameKeyRequest
       // case-7) Check whether dst parent dir exists or not. If parent
       // doesn't exist then throw exception, otw the source can be renamed to
       // destination path.

Review Comment:
   Could we rewrite the comments here? For example, clarifying that here 
handles cases where the destination doesn't exist or is the bucket root. Also, 
could we move the case-7 comment after case-8 and swap their numbers 
accordingly? That would make the code much easier to follow.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to