sadanand48 commented on code in PR #11928: URL: https://github.com/apache/ozone/pull/11928#discussion_r4468298643
########## hadoop-ozone/dist/src/main/compose/xcompat/docker-config: ########## @@ -24,6 +24,8 @@ OZONE-SITE.XML_hdds.scm.safemode.min.datanode=3 OZONE-SITE.XML_ozone.metadata.dirs=/data/metadata OZONE-SITE.XML_ozone.om.address=om OZONE-SITE.XML_ozone.om.http-address=om:9874 +OZONE-SITE.XML_ozone.om.snapshot.diff.optimized.enabled=true +OZONE-SITE.XML_ozone.om.snapshot.force.full.diff=true Review Comment: can we apply both settings only to the new/current cluster instead of in this shared docker-config that is used by both new-cluster.yaml and old-cluster.yaml ozone.om.snapshot.diff.optimized.enabled=true ozone.om.snapshot.force.full.diff=true The first setting is harmless for old clusters, but the second is recognized by them and changes their tested diff path. Scoping both to new-cluster.yaml is clearest and avoids unintended changes to old-cluster coverage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
